Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email )
Change subject: S1GW tests: Add test cases for S1 handover procedure ...................................................................... Patch Set 1: (14 comments) Patchset: PS1: > You're adding new testcases, so please edit `s1gw/expected-results.xml` > accordingly. Done Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/125200c8_ab91e2be?usp=email : PS1, Line 9: preperation > prepare, not prepere Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/e900f8bb_eed91aa8?usp=email : PS1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 > `Related: SYS#7309` Done File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/48079bf9_0fa8687d?usp=email : PS1, Line 71: template TargetID > const c_TargetID Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/760ad866_2470969b?usp=email : PS1, Line 76: /* PLMNidentity */ '62F210'O, > Ack, let's please use field names here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/b27cca8e_eea6cad1?usp=email : PS1, Line 1115: item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id, > cosmetic: alignment issues Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/38a7f95a_45c7d8b1?usp=email : PS1, Line 1185: in ERabList erabs > Unused argument, not needed here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/c07daa34_791d0d1b?usp=email : PS1, Line 1197: in ERabList erabs > Unused argument, not needed here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/6e106b36_c20756a0?usp=email : PS1, Line 1207: ts_TargetID > `tr_TargetID` (receive template, not send). Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/1a3b070a_e55936f0?usp=email : PS1, Line 1629: MME_UE_S1AP_ID mme_ue_id) > cosmetic: alignment issues Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f06a167e_e10c60c4?usp=email : PS1, Line 1678: inout ERabList erabs > This function does not modify the given list, so it should be `in`. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/82934de1_d147348c?usp=email : PS1, Line 1693: inout ERabList erabs > This function does not modify the given list, so it should be `in`. Done File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/db866013_285786da?usp=email : PS1, Line 872: Handover Request > I would say "Handover Preparation procedures" here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/744937ea_92b2ffc0?usp=email : PS1, Line 873: preperation > "prepare", not "prepere" Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Gerrit-Change-Number: 41009 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:36:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de>
