laforge has submitted this change. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41033?usp=email )
Change subject: {gtpu_kpi,pfcp_peer}: do not set trap_exit
......................................................................
{gtpu_kpi,pfcp_peer}: do not set trap_exit
We do not expect nor handle 'EXIT' messages in these modules,
therefore we should not be setting trap_exit.
Change-Id: I966f4a53b8eca6763ca30bae0bbb9e025e6a2c4f
---
M src/gtpu_kpi.erl
M src/pfcp_peer.erl
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/src/gtpu_kpi.erl b/src/gtpu_kpi.erl
index 5aeb749..9432626 100644
--- a/src/gtpu_kpi.erl
+++ b/src/gtpu_kpi.erl
@@ -146,7 +146,6 @@
%% ------------------------------------------------------------------
init([#{enable := true} = Cfg]) ->
- process_flag(trap_exit, true),
TName = maps:get(table_name, Cfg, "osmo-s1gw"),
Interval = maps:get(interval, Cfg, 3000),
%% flush the table, in case it remained
diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl
index a7e9515..efcf0d0 100644
--- a/src/pfcp_peer.erl
+++ b/src/pfcp_peer.erl
@@ -156,7 +156,6 @@
init([LocAddr, RemAddr]);
init([LocAddr, RemAddr]) ->
- process_flag(trap_exit, true),
s1gw_metrics:gauge_set(?S1GW_GAUGE_PFCP_ASSOCIATED, 0),
{ok, Sock} = gen_udp:open(?PFCP_PORT, [binary,
{ip, LocAddr},
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41033?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I966f4a53b8eca6763ca30bae0bbb9e025e6a2c4f
Gerrit-Change-Number: 41033
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
