laforge has submitted this change. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41031?usp=email )
Change subject: s1ap_proxy: add type spec for the eNB-ID
......................................................................
s1ap_proxy: add type spec for the eNB-ID
Change-Id: Ieee55256f1b90a6cf498faedcf11f15da1423c4d
---
M src/s1ap_proxy.erl
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl
index 23e8c1d..fd51b2c 100644
--- a/src/s1ap_proxy.erl
+++ b/src/s1ap_proxy.erl
@@ -64,11 +64,11 @@
-type s1ap_ie_id() :: non_neg_integer().
-type s1ap_ie_val() :: tuple().
+-type enb_id() :: 0..16#fffffff.
-type mme_ue_id() :: 0..16#ffffffff.
-type enb_ue_id() :: 0..16#ffffff.
-type erab_id() :: 0..16#ff.
-type erab_uid() :: {mme_ue_id(), erab_id()}.
-
-type plmn_id() :: {MCC :: nonempty_string(),
MNC :: nonempty_string()}.
@@ -88,7 +88,7 @@
-type proxy_state() :: #proxy_state{}.
-type proxy_action() :: forward | reply | drop.
--type enb_info() :: #{enb_id => non_neg_integer(),
+-type enb_info() :: #{enb_id => enb_id(),
plmn_id => plmn_id(),
genb_id_str => string()
}.
@@ -254,7 +254,7 @@
[?UNHEX(D1), ?UNHEX(D2), ?UNHEX(D3)].
--spec parse_enb_id(tuple()) -> non_neg_integer().
+-spec parse_enb_id(tuple()) -> enb_id().
parse_enb_id({'macroENB-ID', << ID:20 >>}) -> ID;
parse_enb_id({'homeENB-ID', << ID:28 >>}) -> ID;
parse_enb_id({'short-macroENB-ID', << ID:18 >>}) -> ID;
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ieee55256f1b90a6cf498faedcf11f15da1423c4d
Gerrit-Change-Number: 41031
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
