Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email )
Change subject: S1GW: Add test case to test release of e-RABs during handover preperation ...................................................................... Patch Set 3: (6 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/7ddd48f2_a839fc69?usp=email : PS2, Line 1210: in ERabIdxList erabs_release := {}) > For `ERabIdxList`, yes, we don't really need `in/out`. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/17025b7e_7f51ffdf?usp=email : PS2, Line 1247: in ERabIdxList erabs_release := {}) > I vote for stopping adding more "in" churn :D Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/cf3a35e9_6fd72c8c?usp=email : PS2, Line 1720: in ERabIdxList erabs_forward, > Why are you so obsessed with this? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/b79698c9_44299d1f?usp=email : PS2, Line 1718: function f_ConnHdlr_handover_cmd(MME_UE_S1AP_ID mme_ue_id, : ENB_UE_S1AP_ID enb_ue_id, : in ERabIdxList erabs_forward, : > Nitpick: in the existing API, arguments `mme_ue_id` and `enb_ue_id` usually > follow `ERabList`/`ERabI […] Done File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/36a7ea75_683470da?usp=email : PS2, Line 911: for (var integer i := 0; i < lengthof(erabs_forward); i := i + 1) { > I see this logic repeated in several places, so I think it's worth having a > function in `S1GW_ConnHd […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/bcbe3fa7_39a37f30?usp=email : PS2, Line 912: > tabs vs spaces Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic70ba19c0a6e349f63aae124607d075b6d19e779 Gerrit-Change-Number: 41094 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 08:56:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
