Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132?usp=email )
Change subject: RAN_{Emulation,Adapter}: Split transport type from transport
client/server mode
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File library/RAN_Adapter.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132/comment/01c64eff_b208c7c1?usp=email
:
PS2, Line 120: ba.vc_IPA := IPA_Emulation_CT.create(id &
"-IPA") alive;
: map(ba.vc_IPA:IPA_PORT, system:IPA_CODEC_PT);
: /* connect MTP3 service provider (IPA) to lower
side of SCCP */
: connect(ba.vc_IPA:MTP3_SP_PORT,
ba.vc_SCCP:MTP3_SCCP_PORT);
: /* connect waiter to general IPA port (for
ASP_IPA_Event) */
: ba.vc_WAIT := IPA_EventWaiter_CT.create(id &
"-IPA-WAIT") alive;
: connect(ba.vc_IPA:IPA_SP_PORT,
ba.vc_WAIT:IPA_SP_PORT);
:
Unneeded indent level? (shift left)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132/comment/3a61872c_b1c841d5?usp=email
:
PS2, Line 138: /* wait until we received an IPA CCM ID_ACK */
: ba.vc_WAIT.done;
:
Likewise here, why are you adding an indent level?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2e7d029bd7eb59cc6f3b3a28bc417f00d3fed9c
Gerrit-Change-Number: 41132
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Sep 2025 18:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
