Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email )
Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/98ca12dc_07d1da8e?usp=email : PS1, Line 1075: return pdu; > there are many more optional IEs, but for now it's fine as is. Please still put the wildcard template `*` at the end of the list, so that this template would also match PDUs with optional IEs. This is what the other templates do. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e Gerrit-Change-Number: 41082 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 11 Sep 2025 08:04:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
