Attention is currently required from: lynxis lazus, matanp, neels.

jolly has posted comments on this change by matanp. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email )

Change subject: vlr: Stop silent call before deduping subscribers
......................................................................


Patch Set 1:

(1 comment)

File src/libvlr/vlr.c:

https://gerrit.osmocom.org/c/osmo-msc/+/41131/comment/1e55ade5_c5eb7e82?usp=email
 :
PS1, Line 651: gsm_silent_call_stop(
Just a note:

How do we know that there is a silent call going on? Can't there be any other 
reason? If not gsm_silent_call_stop will write a logging error.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If23f8b0e42d4a3a8bf1c8f5ca81b045834b6cccd
Gerrit-Change-Number: 41131
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-CC: jolly <andr...@eversberg.eu>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Attention: lynxis lazus <lyn...@fe80.eu>
Gerrit-Attention: matanp <matan1...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 11:09:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to