Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email )
Change subject: MME-Tests: Add test for emergency bearer setup ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File mme/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/497bb19e_23cfbea5?usp=email : PS2, Line 397: char2oct(apn) wouldn't it make sense to define "var octetstring apn := O'00000004' & char2oct("test") & O'00000003' & char2oct("sos");" instead, so we don't have to convert it here in the compare? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46 Gerrit-Change-Number: 41189 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 01 Oct 2025 14:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
