Attention is currently required from: fixeria, keith, pespin.

osmith has posted comments on this change by keith. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email )

Change subject: sqlite optimisation: Avoid unneeded database operation
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

File src/libmsc/db.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/aabee786_c13e0fb3?usp=email
 :
PS4, Line 302: id = $id LIMIT 1
> Not sure if this really a standard practice, given that not all database 
> bacnends support the `LIMIT […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603
Gerrit-Change-Number: 28340
Gerrit-PatchSet: 7
Gerrit-Owner: keith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: keith <[email protected]>
Gerrit-Comment-Date: Fri, 24 Oct 2025 06:44:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: keith <[email protected]>

Reply via email to