Attention is currently required from: dexter, osmith.

laforge has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/41251?usp=email )

Change subject: pySim-shell: allow user friendly selection of the pin type
......................................................................


Patch Set 2:

(1 comment)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/41251/comment/320cb227_e9bab154?usp=email :
PS2, Line 942:
vague hypothesis regarding the linter error: it might be that (the linter 
things) this is not possible for a staticmethod, as it might be called from 
some very early code at runtime at a time the inverse property has not been set 
up yet?

Otherwise I don't see why in line 857 the same approach passses the linter, 
while here it doesn't



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41251?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0b58c402d95cbc4fe690e6edb214829d463e9f2c
Gerrit-Change-Number: 41251
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Fri, 31 Oct 2025 14:00:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to