Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email )

Change subject: stp: Introduce STP_Tests_TCAP
......................................................................


Patch Set 6:

(2 comments)

File stp/STP_Tests_TCAP.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/5d20c3c7_a83677ca?usp=email
 :
PS6, Line 48: import from STP_Tests_Common all;
duplicate (already imported above)


File stp/expected-results.xml:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136/comment/7f9e30d9_9e70d44c?usp=email
 :
PS6, Line 75:   <testcase classname='STP_Tests_TCAP' 
name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/>
            :   <testcase classname='STP_Tests_TCAP' 
name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/>
            :   <testcase classname='STP_Tests_TCAP' 
name='TC_tcap_loadshare_ipa_tcap_range_fail_overlap' time='MASKED'/>
            :
> copy-pasted
Ok, I see you're executing the same testcase with different parameters.
Not critical, but I think it does not make sense to have duplicate entries here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41136?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4340bdf126118c66af861f5a447e90883783920e
Gerrit-Change-Number: 41136
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Sun, 02 Nov 2025 18:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to