Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email )
Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Patch Set 1: (5 comments) File src/host/layer23/src/common/settings.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9e504b0c_1a0b247d?usp=email : PS1, Line 187: for(i = 940; i <= 954; i++) space required before the open parenthesis '(' File src/target/firmware/apps/rssi/main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/6bc36477_69543215?usp=email : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/121462b5_86ff8d43?usp=email : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9fb1599e_1e9761af?usp=email : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/89aa4c5b_daee1dd4?usp=email : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Nov 2025 10:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
