Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email )
Change subject: tests/testsuite.at: use AT_SKIP_IF for sim_test ...................................................................... Patch Set 1: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmocore/+/41363/comment/ef2aeed7_9ed64591?usp=email : PS1, Line 320: AT_SKIP_IF([test ! -e $abs_top_builddir/tests/sim/sim_test]) > AFAIU this would also be done with: […] See my comment to the previous patch: we would have to pass `ENABLE_PCSC=$ENABLE_PCSC` (and all the other variables like this one) manually to the testsuite script. I believe checking if the binary exists is a lot simpler. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic90b3a39936888eda6c9d443420c4faa131ac78f Gerrit-Change-Number: 41363 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 07 Nov 2025 08:39:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
