Attention is currently required from: osmith.

laforge has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email )

Change subject: Fix lint errors: don't use star imports
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File tests/test_construct.py:

https://gerrit.osmocom.org/c/python/pyosmocom/+/41384/comment/5d22a710_e792c312?usp=email
 :
PS2, Line 8:     DnsAdapter,
we're not using this parenthesized list with one item per line anywhere else.  
I'm not sure we should introduce completely different coding style all of a 
sudden?



--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266
Gerrit-Change-Number: 41384
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Sat, 08 Nov 2025 13:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to