Attention is currently required from: fixeria, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email )

Change subject: build-system: depend on libosmo-asn1-tcap
......................................................................


Patch Set 3:

(4 comments)

This change is ready for review.

Patchset:

PS1:
> unresolv it.
Done


Patchset:

PS3:
> Also, libosmo-sigtran.pc. […]
done


File configure.ac:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/ef694ae9_03519c6e?usp=email
 :
PS2, Line 53: ENABLE_EXT_TESTS
> why do you add `ENABLE_EXT_TESTS` here? looks like copy-paste
Done


File contrib/jenkins.sh:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/f2f3f057_cd6ba297?usp=email
 :
PS3, Line 66: echo " =============================== libosmo-sigtran / 
tcap-loadsharing ==============================="
> You shouldn't test --enable-tcap this way, look at how we test differnet 
> matrix of --enable configs  […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634
Gerrit-Change-Number: 41307
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Sun, 09 Nov 2025 11:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to