Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email )
Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > I don't see the point in having this here (polluting osmo-stp with more > unnecessary tcap code) which […] Agreeing with Pau. Unit tests for TCAP codec should be in libosmo-asn1-tcap.git. Otherwise, one can submit a breaking change without even noticing because we don't seem to have any tests there... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
