Jenkins Builder has posted comments on this change by daniel. ( 
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email )

Change subject: Add test to ensure parsing works
......................................................................


Patch Set 1:

(2 comments)

File tests/parse/tcap_parse_test.c:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/f9c1d2c5_7faa76de?usp=email
 :
PS1, Line 20: static int write_stream(const void *buffer, size_t size, void 
*key) {
open brace '{' following function definitions go on the next line


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394/comment/68e893ad_8852e4b6?usp=email
 :
PS1, Line 37:   if (rc.code != RC_OK) {
braces {} are not necessary for single statement blocks



--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41394?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I475afbb6145404934b0838f9b418c105bf65dca0
Gerrit-Change-Number: 41394
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 11 Nov 2025 08:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to