Attention is currently required from: fixeria, laforge, pespin.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email )

Change subject: Add ER-GSM band support to all relevant applications
......................................................................


Patch Set 4:

(2 comments)

File src/host/layer23/src/common/sysinfo.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/e0a4d5db_d0af9fa7?usp=email
 :
PS3, Line 406:  return gsm48_decode_freq_list(f, cd, len, mask, frqt);
> Just to be sure, did you make sure this API in libosmocore. […]
I looked at the gsm48_decode_freq_list() function. Except for the P-BAND 
(1..124) the frequency lists are not related to any band range.


File src/shared/libosmocore/src/gsm/gsm_utils.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/483dd9d8_31a8e274?usp=email
 :
PS3, Line 484:  else if (arfcn >= 940 && arfcn <= 1023)
> I agree. Or even better: update the libosmocore in osmocom-bb using 
> update-libosmocore.sh. […]
I tried to update libosmocore and talked to pespin and fixeria. There are too 
many dependencies, so we decided not to do this now.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f
Gerrit-Change-Number: 41359
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 13 Nov 2025 10:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to