Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41420?usp=email )
Change subject: testenv: wait_for_port: add --protocol=sctp ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File _testenv/data/scripts/wait_for_port.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41420/comment/32e337df_36a1bd76?usp=email : PS1, Line 33: if "sctp" not in sys.modules: : print("python module sctp is not installed, sleeping 3s instead...") : time.sleep(3) : Can you just use `try-catch` here instead? ```suggestion try: import sctp except ImportError: print("python module sctp is not installed, sleeping 3s instead...") time.sleep(3) return ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e75728b2e9b67c85d1ea2ae5ab15890074db272 Gerrit-Change-Number: 41420 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 06:10:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
