Harald Welte has submitted this change and it was merged.
Change subject: SS7: clarify handling of stream opening error
......................................................................
SS7: clarify handling of stream opening error
Add comment clarifying why we've just logged error but continued anyway.
Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9
---
M src/osmo_ss7.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 7f82f6e..30677b9 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1251,6 +1251,8 @@
if (rc < 0) {
LOGSS7(asp->inst, LOGL_ERROR, "Unable to open stream"
" client for ASP %s\n", asp->cfg.name);
+ /* we don't return error in here because
osmo_stream_cli_open2()
+ will continue to retry to connect so the error is
transient */
}
/* TODO: make this configurable and not implicit */
role = XUA_ASPFSM_ROLE_ASP;
--
To view, visit https://gerrit.osmocom.org/6407
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
