pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email )
Change subject: sigtran: Fix potential null ptr derreference
......................................................................
sigtran: Fix potential null ptr derreference
Related: Coverity CID#551476
Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/41495/1
diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index db8b6f3..1fe7739 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -888,12 +888,12 @@
msc->a.mtp_user = osmo_ss7_user_find_by_si(s7i,
MTP_SI_NI11_OSMO_IPA);
if (!msc->a.mtp_user) {
msc->a.mtp_user =
osmo_ss7_user_create(s7i, "MGCP/CTRL-IPA");
+ if (!msc->a.mtp_user)
+ return -EINVAL;
osmo_ss7_user_set_prim_cb(msc->a.mtp_user, mtp_sap_up);
osmo_ss7_user_set_priv(msc->a.mtp_user,
s7i);
osmo_ss7_user_register(msc->a.mtp_user,
MTP_SI_NI11_OSMO_IPA);
}
- if (!msc->a.mtp_user)
- return -EINVAL;
}
/* Start MSC-Reset procedure */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iab7c237dd0ab5d6e916ee0a680559cdf838c509f
Gerrit-Change-Number: 41495
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
