Attention is currently required from: fixeria, jolly, laforge.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email )

Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params
......................................................................


Patch Set 2:

(1 comment)

File config/sys.config:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/733d9bde_264b95b8?usp=email
 :
PS2, Line 17:       %% * rto_initial - RTO (retransmission time-out) initial, 
ms (default: 1000)
> do you mind sharing to which sysctls/sockopts those values relate?
Linux sysctl defaults on 6.17.8-arch1-1:
net.sctp.rto_initial = 3000
net.sctp.rto_max = 60000

net.sctp.rto_min = 1000


tbh, a rto_max of 1s for a satellite link looks a bit constrained to me.And 
iiuc by setting both rto_min and max to 1000 you are in practice establishing 
the RTO to 1000 in all cases, which may be suboptimal and problematic since you 
don't give the kernel space to accommodate to current connection status.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3
Gerrit-Change-Number: 41531
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: jolly <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 01 Dec 2025 15:38:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to