Attention is currently required from: daniel, pespin.

fixeria has posted comments on this change by daniel. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email )

Change subject: Link tests dynamically
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534/comment/a39b67c0_da1037de?usp=email
 :
PS1, Line 7: dynamically
BTW, tests are currently linked dynamically despite the `-static` (not sure if 
it does anything at all). By linking with `*.a` you actually link the binaries 
against those `*.a` files statically.


It might be me using different automake/libtool versions, but with and without 
this patch I am getting this (note the `dynamically linked`):
```
libosmo-sigtran$ file tests/xua/xua_test
tests/xua/xua_test: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), 
dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, 
BuildID[sha1]=e1300c5a2faf7d859d5b649de7ce7dbd73e79523, for GNU/Linux 4.4.0, 
not stripped

```

The only difference is `libosmo-sigtran.so` not showing up in ldd output with 
your patch, because you're now linking it _statically_ (all `*.o` objects 
become part for the test binaries).



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I074f243b62a516534099c88f691a28065cd763dd
Gerrit-Change-Number: 41534
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Tue, 02 Dec 2025 14:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to