Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )
Change subject: logging: change gsmtap target to use wqueue by default ...................................................................... Patch Set 1: (1 comment) File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/b51d971e_7d41e010?usp=email : PS1, Line 1047: if (tgt->tgt_gsmtap.ofd_wq_mode) > You don't need here the new field tgt->tgt_gsmtap.ofd_wq_mode: […] I would do exactly that if `struct gsmtap_inst` were public, but it's not. It's an opaque struct for us here and we cannot access its fields. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0 Gerrit-Change-Number: 41685 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 16 Dec 2025 13:25:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
