Attention is currently required from: dexter, laforge. neels has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email )
Change subject: pySim.esim.saip.personalization: Support Milenage customization ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: general remark: on my saip branch, I will need each ConfigurableParameter to be able to convert some or other string input to the correct type. You don't need to worry about this here, i have it covered on the branch. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41690/comment/f7c28278_0be1b87e?usp=email : PS1, Line 327: Provided as octet-string concatenation of all 5 constants.""" Which type exactly goes into the PES? I assume it is a bytes() of len() = 5 octets? i.e. not a hex string, right? (i'm pretty sure it's not, but from the doc one could get the idea that the highest unused bit might be stripped to leave 5 * 7 bits) https://gerrit.osmocom.org/c/pysim/+/41690/comment/0650529a_bde4714d?usp=email : PS1, Line 341: super().validate() > Looks like you want to call this first, before checking length of something > that may not be a `bytes […] (On my branch I will inherit from BinaryParam,AlgoConfig and set allowed_len, so this won't need its own validate() implementation. That can happen later when the branch gets merged.) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6 Gerrit-Change-Number: 41690 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 21:02:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
