laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/41712?usp=email )
Change subject: pyshark_gsmtap: Adjust display filter for some wireshark
versions
......................................................................
pyshark_gsmtap: Adjust display filter for some wireshark versions
On my debian unstable system with wireshark 4.6.2-3, the pyshark_gsmtap
APDU source misses to report any ATRs, as those are not part of what's
reported with the 'gsm_sim' display filter. Instead, let's use
'gsmtap.type == 4' instead, which is also backwards compatible to older
wireshark versions.
Change-Id: I53c1c8ed58a82c37cd4be4af3890af21da839e86
---
M pySim/apdu_source/pyshark_gsmtap.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/41712/1
diff --git a/pySim/apdu_source/pyshark_gsmtap.py
b/pySim/apdu_source/pyshark_gsmtap.py
index e8f5d18..5232db4 100644
--- a/pySim/apdu_source/pyshark_gsmtap.py
+++ b/pySim/apdu_source/pyshark_gsmtap.py
@@ -84,5 +84,5 @@
Args:
pcap_filename: File name of the pcap file to be opened
"""
- pyshark_inst = pyshark.FileCapture(pcap_filename,
display_filter='gsm_sim', use_json=True, keep_packets=False)
+ pyshark_inst = pyshark.FileCapture(pcap_filename,
display_filter='gsmtap.type == 4', use_json=True, keep_packets=False)
super().__init__(pyshark_inst)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I53c1c8ed58a82c37cd4be4af3890af21da839e86
Gerrit-Change-Number: 41712
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
