Attention is currently required from: falconia, fixeria.

pespin has posted comments on this change by falconia. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email )

Change subject: add vty setting for ThemWi RTP formats
......................................................................


Patch Set 5:

(2 comments)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/8d1ddf0d_1107615a?usp=email
 :
PS5, Line 10: vty               >1.12.0                 working 
optional-multi-choice
libosmovty
You can use ">=1.12.1" here, since it's more precise and I already did a patch 
release today with it.


File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/471d19fc_3f03baff?usp=email
 :
PS5, Line 694:       "tw-rtp-formats (fr|hr|amr|csd) [(fr|hr|amr|csd)] 
[(fr|hr|amr|csd)] [(fr|hr|amr|csd)]",
You can put "(fr|hr|amr|csd)" in a define above and use it here 4 times.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
Gerrit-Change-Number: 41698
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 18 Dec 2025 17:50:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to