Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email )

Change subject: RAN_Emulation: Support Tx RESET retries in RANAP
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1:
Thanks for adding this, I ran into such reset errors because of no retries 
quite a lot!


File library/RAN_Emulation.ttcnpp:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723/comment/0ce4fdb9_4fc959dd?usp=email
 :
PS1, Line 821: [] as_reset_ack();
> Otherwise we are not rescheduling the timer properly.

Not sure if this means rescheduling T (5s), but if yes, then it probably 
doesn't make sense to reschedule it? It seems to me that if the whole reset 
routine takes more than 5s, we should get an error instead of retrying.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41723?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I84553ae7aee19efa007bae060d7f7ca218a5f306
Gerrit-Change-Number: 41723
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to