Attention is currently required from: daniel, dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email )
Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/93e6a195_f50a4150?usp=email : PS8, Line 37: PQSQL PGSQL or PSQL are usual acronyms for postgres. But not PQSQL https://gerrit.osmocom.org/c/pysim/+/41508/comment/16159947_6e3bcf78?usp=email : PS8, Line 261: str(Path.home()) + "/.osmocom/pysim/card_data_pqsql.cfg" Not critical, but I guess the clean/pythonic way would be to use `os.path.join() to concatenate paths. Furthermore, you can use `os.path.expanduser("~/.osmocom/pysim/card_data_pgsql.cfg")` to avoid nany manual concatenation whatsoever. If that is needed at all? Why should the help print the absolute path instad the ~/... referring to the users home? Keeping the "~" would make he help output consistent across systems, and not expose user names (through directory names) if someone copy+pastes something into a bug report or mailing list / forum post. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 19 Dec 2025 23:26:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
