Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41735?usp=email )
Change subject: pySim.esim.saip.personalization: Support for EF.SMSP personalization ...................................................................... Patch Set 5: Code-Review+2 (4 comments) Patchset: PS5: I have now carefully looked at this. To my eyes, everything looks fine. I also thing that you have already tried that out somewhere. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41735/comment/904ba84c_cfcd40a4?usp=email : PS5, Line 129: for pe in pes.get_pes_for_type('usim'): I am not 100% sure here, maybe our application does not even require this. But in "eUICC Profile Package: Interoperable Format Technical Specification" I see that the ED.SMSP not only appears in USIM, it appears in ISIM and CSIM as well, but as optional files. https://gerrit.osmocom.org/c/pysim/+/41735/comment/6ee93085_3a48a739?usp=email : PS5, Line 131: f_smsp = pe.files['ef-smsp'] This should be ok, in "eUICC Profile Package: Interoperable Format Technical Specification", section 9.5.1 I can see that EF.SMSP is on the list with the mandatory files, so it should be always there. https://gerrit.osmocom.org/c/pysim/+/41735/comment/b5f6fa0e_5631de6b?usp=email : PS5, Line 132: #print("SMSP (orig): %s" % f_smsp.body) Do you want to keep this commented out debug print? (there is another one below) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6b0776c2e753e0a6d158a8cf65cb030977782ec2 Gerrit-Change-Number: 41735 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 22 Dec 2025 14:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
