Attention is currently required from: laforge.
dexter has posted comments on this change by laforge. (
https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email )
Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_*
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/core/msgb.c:
https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/63c57054_58af55e5?usp=email
:
PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb
part is not copied.
> I think the cb was not copied as a performance reason, since lots of code
> doesn't use cb at all. […]
I wonder how much the performance impact of copying the cb buffer would be. The
additional effort should be neglectable. While the function was specified not
to copy the cb, it thereis nothing said about msg->lchan and msg->dst. Maybe we
could just drop the memcpy line?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5
Gerrit-Change-Number: 36324
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Mon, 22 Dec 2025 14:56:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
