Patch Set 3: The sister function pcu_bitcount() is used on wider types (e.g. see find_multi_slots() which uses it with unsigned int).
I think from an API point of view it makes more sense to keep both functions consistent. Is the goal to get rid of templates? In that case, why not use uint32_t or even uint64_t so pcu_lsb() can be applied to any integer type? -- To view, visit https://gerrit.osmocom.org/6105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-HasComments: No
