Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email )
Change subject: nft_kpi: add udp/2152 filtering rules separately ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/nft_kpi.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752/comment/25dee18f_81433595?usp=email : PS3, Line 328: static int do_add_chain(bool uplink) > While I agree with implementing a fix, I dislike the result as done in this > patch because: […] I particularly agree with pespin's second comment. There's no reason to change from a single atomic nft_run_now call to multiple iteratively. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I36eb3b18751fc029297fb91545af2d28e61067fd Gerrit-Change-Number: 41752 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 23 Dec 2025 20:08:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
