Patch Set 3: (2 comments)
https://gerrit.osmocom.org/#/c/6471/3//COMMIT_MSG Commit Message: Line 38: handover2 window rxlev averaging 7 What about using a node instead of prepending the algorithm to each command? https://gerrit.osmocom.org/#/c/6471/3/src/libbsc/handover_decision.c File src/libbsc/handover_decision.c: Line 218: avg = neigh_meas_avg(nmp, ho_get_hodec1_rxlev_neigh_avg_win(bts->ho)); I think it makes more sense to call this ho_hodec1_{get,set}_*, as it's part of the scope/namespace imho. Also I'm not sure now what hodec1 stands for now, but you can at least drop the second "ho": ho_dec1_*, or use something like ho_alg1_* or ho_1_*. -- To view, visit https://gerrit.osmocom.org/6471 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6475b2543b18d21710a6d774b214cb484f36ec8e Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
