pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email )
Change subject: ta_power_control: reset during lchan activation
......................................................................
ta_power_control: reset during lchan activation
This way lchan->ta_ctrl.skip_block_num is also reset to 0 during chan
re-activation case, in which case we allow the TA control loop to kick
in during first input after re-activation.
Change-Id: I149fffa73ef651fd21e52e5423b31f8e95e57941
---
M src/common/rsl.c
M src/common/ta_control.c
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/src/common/rsl.c b/src/common/rsl.c
index e620545..23207b2 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2055,10 +2055,9 @@
}
/* 9.3.24 Timing Advance */
+ lchan_ms_ta_ctrl_reset(lchan);
if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1))
lchan->ta_ctrl.current = *TLVP_VAL(&tp, RSL_IE_TIMING_ADVANCE);
- else /* assume TA=0 if not indicated by the BSC */
- lchan->ta_ctrl.current = 0;
/* 9.3.31 (TLV) MS Power Parameters IE (vendor specific) */
if ((ie = TLVP_GET(&tp, RSL_IE_MS_POWER_PARAM)) != NULL) {
diff --git a/src/common/ta_control.c b/src/common/ta_control.c
index b5d9cb2..85e5f81 100644
--- a/src/common/ta_control.c
+++ b/src/common/ta_control.c
@@ -46,6 +46,7 @@
{
/* Trigger loop on first TA input: */
lchan->ta_ctrl.skip_block_num = 0;
+ /* Assume TA=0 if not indicated by the BSC */
lchan->ta_ctrl.current = 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I149fffa73ef651fd21e52e5423b31f8e95e57941
Gerrit-Change-Number: 41796
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
