Attention is currently required from: phcoder. fixeria has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email )
Change subject: Print SMSC in pySim-read.py ...................................................................... Patch Set 14: (1 comment) File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/41786/comment/ddc12aea_0d8520b7?usp=email : PS14, Line 148: smsc_a.get('ton_npi', None).get `smsc_a.get()` may return `None`, resulting in an exception: ``` AttributeError: 'NoneType' object has no attribute 'get' ``` Same applies to `smsc_n.get()` above: `smsc_n` can be `None`, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 14 Gerrit-Owner: phcoder <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: phcoder <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 12:55:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
