Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )
Change subject: build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac. ...................................................................... Patch Set 1: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/0ce0dba1_9ef31925?usp=email : PS1, Line 242: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes") > In this patch, ENABLE_TUN is a noop, so it doesn't make sense to have a patch > containing that imho. […] Agreed. I'll drop ENABLE_TUN from this patch and just use !EMBEDDED. For Emscripten I'll add a proper configure-time capability check for the actual tun.c dependency and exclude it only when that check fails. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 20 Jan 2026 14:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
