Attention is currently required from: pespin.

Timur Davydov has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )

Change subject: build: control USE_NETNS via configure.ac
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS2:
> I'm waiting for this information before continuing with the review.
There is actually no build-time or runtime failure with netns.c on Emscripten.
Emscripten is able to compile it just fine.

The issue was that netns.c used to be excluded unconditionally by
`#if defined(__linux__)`, so it was never built for Emscripten at all.
The change moves that decision to configure time (`USE_NETNS`), so the file
can be built when the target supports it, instead of being hard-wired to
__linux__.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea
Gerrit-Change-Number: 41878
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 20 Jan 2026 22:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to