Attention is currently required from: canghaiwuhen. fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email )
Change subject: Related: OS#6922 Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 1: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/c6c411a7_3a11cc9a?usp=email : PS1, Line 7: Related: OS#6922 This should go below or above the `Change-Id` line, not here. File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/7892495d_fe27ee45?usp=email : PS1, Line 210: ANTIGRAVITY PATCH: True Echo. What does this mean? https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/8c74248f_21001559?usp=email : PS1, Line 219: if (qos_len > sizeof(default_qos)) ```suggestion else if (qos_len > sizeof(default_qos)) ``` https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/9ffadd97_72c398ca?usp=email : PS1, Line 340: tp->lv[OSMO_IE_GSM_REQ_QOS].len ```suggestion pdp->req_qos_len = TLVP_LEN(tp, OSMO_IE_GSM_REQ_QOS); ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 1 Gerrit-Owner: canghaiwuhen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: canghaiwuhen <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 14:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
