Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38014?usp=email )
Change subject: pySim.esim.saip: Implement optimized file content encoding ...................................................................... Patch Set 6: (2 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38014/comment/8dc1dd68_93276169?usp=email : PS6, Line 61: assert match.a >= cur maybe return also return a ValueError? (The caller does not have to check for the ValueError and raise an exception? We return ValueErrors in other modules too, but I don't really get the concept) https://gerrit.osmocom.org/c/pysim/+/38014/comment/a672edec_36f63d2d?usp=email : PS6, Line 463: ret.append(('fillFileOffset', block.a - cur)) cur is set to 0 at the beginning but it does not get re-assigned. Maybe there is something missing here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I61e4a5e04beba5c9092979fc546292d5ef3d7aad Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 15:20:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
