[S] Change in libosmo-netif[master]: stream: make SCTP usage conditional on HAVE_LIBSCTP

[pespin]

Attention is currently required from: Timur Davydov.

pespin has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email )

Change subject: stream: make SCTP usage conditional on HAVE_LIBSCTP
......................................................................


Patch Set 1:

(3 comments)

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/88ea3148_8979bd64?usp=email
 :
PS1, Line 53: #include <osmocom/netif/sctp.h>
You can actually simply move this below inside the ifdef in line 58.


File src/stream_cli.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/cf85410c_b602231a?usp=email
 :
PS1, Line 1273:                         local_addrcnt = cli->local_addrcnt;
You could do

    case IPPROTO_SCTP:
    {
     unsigned int local_addrcnt = cli->local_addrcnt;
     int flags = OSMO_SOCK_F_CONNECT | OSMO_SOCK_F_NONBLOCK |
                                OSMO_SOCK_F_DSCP(cli->ip_dscp) | 
OSMO_SOCK_F_PRIO(cli->sk_prio);
    ...
    }

to simplify a bit the ifdef blocks.


File src/stream_srv.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/9a5273d9_f8ad5300?usp=email
 :
PS1, Line 1050: #ifdef HAVE_LIBSCTP
#ifdef HAVE_LIBSCTP
        if (link->proto == IPPROTO_SCTP) {
            ....
        } else
    #endif
        {
        ...
        }



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65
Gerrit-Change-Number: 41952
Gerrit-PatchSet: 1
Gerrit-Owner: Timur Davydov <dtv.c...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.c...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Jan 2026 16:23:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No