Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email )
Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... Patch Set 3: (4 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/3454230a_e2a27094?usp=email : PS1, Line 38: log = PySimLogger.get(__name__) > Indeed, `log` should be accessible globally. […] I have re-tested this. There seems to be no problem when removing the line. I think I was just irritated. Maybe the problems I had when I was writing the original code were caused by something else that resolved itself later. File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/ac897176_428d8634?usp=email : PS2, Line 15: log = PySimLogger.get("csv-to-pqsql") > you can generalize this with […] Thanks for the hint. This works fine. I have updated it now in the other code locations as well. File contrib/es2p_server.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/6da24d19_7e307dbe?usp=email : PS2, Line 35: logger = logging.getLogger("es2p_server") > you can generalize this with […] Done File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/67cfccd3_240db4ec?usp=email : PS1, Line 41: PySimLogger.get > I was wrong about inheriting configuration of the parent loggers then. […] ACK, then we work on this later. I think it would be great if we could make it work this way. Things would be a lot simpler then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 28 Jan 2026 11:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: dexter <[email protected]>
