Attention is currently required from: laforge.

dexter has posted comments on this change by laforge. ( 
https://gerrit.osmocom.org/c/pysim/+/41972?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: es9p_client: smdpOid is optional in download/install 
notification
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1:
With the patch itself, everything looks good, but I have problems to understand 
why smdpOid is suddenly optional. Let's double check this first.


Commit Message:

https://gerrit.osmocom.org/c/pysim/+/41972/comment/e9414046_e6208a3e?usp=email :
PS1, Line 14:     smdpOid OBJECT IDENTIFIER OPTIONAL, -- SM-DP+ OID (same value 
as in CERT.DPpb.ECDSA)
This field is not marked as optional in V.2.5 (At least not in my copy RSP 
Technical Specification Version 2.5 26 May 2023). I have also checked against 
SGP.22 v3.1 (RSP Technical Specification
Version 3.1 Final 01 December 2023) and there it is also not optional. Now I am 
confused. Can you point me to the spec where this is coming from?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41972?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5df54df2ddc0590a5eca31d4f37ae94053d20067
Gerrit-Change-Number: 41972
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Fri, 30 Jan 2026 15:15:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to