Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email )
Change subject: bts: f_verify_ramp_up(): fix RxLev / dBm mixup ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022/comment/28830f85_b700250d?usp=email : PS2, Line 2804: Misc_Helpers.f_shutdown(__BFILE__, __LINE__); > Next time you review my patches please don't tell me to avoid changing the > formatting of these ;) Just to be clear, adding dBm units makes the strings even longer. I could have kept these clumsy `log2str()` constructs, but editing and reading them gets even harder as the amount of arguments grows. Hence I changed to `setverdict(fail, ...)`. But since this is mostly your code, I can revert back to using `log2str()` if you prefer. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I818d18d6e0711247b73ee1f336133e2ed3f6e2cb Gerrit-Change-Number: 42022 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 04 Feb 2026 07:44:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
