Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email )

Change subject: osmo-bts-trx: apply 'max-initial' value before POWERON
......................................................................


Patch Set 2:

(2 comments)

File src/osmo-bts-trx/trx_provision_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/0daae303_26cda3b4?usp=email
 :
PS2, Line 229:          l1h->config.setpower_sent = true;
> Missing: "l1h->config.nomtxpower_acked = false;" […]
Acknowledged


https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/b35fffec_e2d7bfce?usp=email
 :
PS2, Line 294:      (l1h->config.setformat_acked) &&
> This () can actually be dropped, instead of adding new ones 😊
I prefer to have those braces, so that this new line is aligned with the 
existing ones.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff03d4dcb74f67629a59c8d6f8bb60929d9f6ddd
Gerrit-Change-Number: 42033
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 04 Feb 2026 12:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to