pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42048?usp=email )


Change subject: vty: Allow configuring xua server in ASP mode
......................................................................

vty: Allow configuring xua server in ASP mode

The xua server has nothing to do with a node being an ASP or an SG,
it used to allow transport server features (SCTP/TCP server).
One may want to configure an ASP role with a SCTCP server.

Change-Id: I9b07d2c96404b7b86c51fd9c7bab5e52a2343ade
---
M src/ss7_vty.c
M tests/vty/osmo_stp_test.vty
M tests/vty/ss7_asp_test.vty
3 files changed, 8 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran 
refs/changes/48/42048/1

diff --git a/src/ss7_vty.c b/src/ss7_vty.c
index a61229f..56633f3 100644
--- a/src/ss7_vty.c
+++ b/src/ss7_vty.c
@@ -1548,6 +1548,8 @@

        gen_cs7_timer_xua_cmd_strs(&cs7_timer_xua_cmd);
        install_lib_element(L_CS7_NODE, &cs7_timer_xua_cmd);
+
+       ss7_vty_init_node_oxs();
 }

 void osmo_ss7_vty_init_asp(void *ctx)
@@ -1569,6 +1571,4 @@
        install_lib_element(L_CS7_RTABLE_NODE, &cfg_description_cmd);
        install_lib_element(L_CS7_RTABLE_NODE, &cs7_rt_upd_cmd);
        install_lib_element(L_CS7_RTABLE_NODE, &cs7_rt_rem_cmd);
-
-       ss7_vty_init_node_oxs();
 }
diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty
index 1114a2c..61cbd66 100644
--- a/tests/vty/osmo_stp_test.vty
+++ b/tests/vty/osmo_stp_test.vty
@@ -133,9 +133,9 @@
   sccp-address NAME
   no sccp-address NAME
   timer xua (T8) <1-999999>
-  route-table system
   listen (sua|m3ua|ipa) <0-65534> [(sctp|tcp)]
   no listen (sua|m3ua|ipa) <0-65534> [(sctp|tcp)]
+  route-table system
   sccp-timer (conn_est|ias|iar|rel|repeat_rel|int|guard|reset|reassembly) 
<1-999999>
   sccp max-optional-data (<0-999999>|standard)

@@ -153,8 +153,8 @@
   as                 Configure an Application Server
   sccp-address       Create/Modify an SCCP addressbook entry
   timer              Configure CS7 Instance default timer values
-  route-table        Specify the name of the route table
   listen             Configure/Enable xUA Listener
+  route-table        Specify the name of the route table
   sccp-timer         Configure SCCP timer values, see ITU-T Q.714
   sccp               Configure SCCP behavior

diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty
index 2c27984..0cd0c39 100644
--- a/tests/vty/ss7_asp_test.vty
+++ b/tests/vty/ss7_asp_test.vty
@@ -131,6 +131,8 @@
   sccp-address NAME
   no sccp-address NAME
   timer xua (T8) <1-999999>
+  listen (sua|m3ua|ipa) <0-65534> [(sctp|tcp)]
+  no listen (sua|m3ua|ipa) <0-65534> [(sctp|tcp)]
   sccp-timer (conn_est|ias|iar|rel|repeat_rel|int|guard|reset|reassembly) 
<1-999999>
   sccp max-optional-data (<0-999999>|standard)

@@ -148,6 +150,7 @@
   as                 Configure an Application Server
   sccp-address       Create/Modify an SCCP addressbook entry
   timer              Configure CS7 Instance default timer values
+  listen             Configure/Enable xUA Listener
   sccp-timer         Configure SCCP timer values, see ITU-T Q.714
   sccp               Configure SCCP behavior

@@ -214,6 +217,7 @@
   asp           Disable Application Server Process
   as            Disable Application Server
   sccp-address  Delete an SCCP addressbook entry
+  listen        Disable xUA Listener on given port
 ss7_asp_vty_test(config-cs7)# no asp ?
   NAME  Name of ASP
 ss7_asp_vty_test(config-cs7)# no as ?

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42048?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I9b07d2c96404b7b86c51fd9c7bab5e52a2343ade
Gerrit-Change-Number: 42048
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>

Reply via email to