Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email )
Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... Patch Set 1: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/de9ec6d0_acd54198?usp=email : PS1, Line 247: return asp; > How do you return back a NULL in case non of the given asp is valid? ACK. It probably makes sense to assign last_asp_idx_sent and return asp inside the condition in the loop, and return NULL here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 16:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <[email protected]>
