Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email )
Change subject: osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/42046/comment/84f93a43_c5b69550?usp=email : PS1, Line 12: ensuring that only successful operations generate confirmation events. > This sounds like a workaround, why not adjust trx_provision_fsm to check the > event data instead? I guess we could change the FSM to shutdown immediately if some command fails. But that would be a lot more changes to the existing code. For now it's easier if the FSM remains stuck in the provisioning loop and then we fail due to a timeout. The current approach is not perfect, but still better than ignoring failures and declaring readiness to the BSC. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id85fb19c6621f55a9c46882df24bec534864a9dc Gerrit-Change-Number: 42046 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:32:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]>
