pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email )


Change subject: xua_aspm_fsm: Remove unneeded workaround submitting 
XUA_ASP_E_M_ASP_ACTIVE_REQ
......................................................................

xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ

Sending that kind of event is up to the layer manager.
Right now, all ASPs (except ipa_aspm_fsm, which don't need that event
because there's no ACTIVATE in IPA) have an associated layer manager
FSM, so that workaround is not needed.

Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
---
M src/xua_asp_fsm.c
1 file changed, 0 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran 
refs/changes/90/42090/1

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index d3a7410..5ae0d0f 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -571,10 +571,6 @@
                osmo_fsm_inst_state_chg(fi, XUA_ASP_S_INACTIVE, 0, 0);
                /* inform layer manager */
                send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_UP, 
PRIM_OP_CONFIRM);
-               /* This hack should be in layer manager, but let's try
-                * to be smart in case there is no layer manager */
-               if (!asp->lm)
-                       osmo_fsm_inst_dispatch(fi, XUA_ASP_E_M_ASP_ACTIVE_REQ, 
NULL);
                break;
        case XUA_ASP_E_ASPSM_ASPUP:
                /* only if role SG */

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
Gerrit-Change-Number: 42090
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>

Reply via email to