pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42114?usp=email )
Change subject: xua_as_fsm: Remove TODO no longer valid
......................................................................
xua_as_fsm: Remove TODO no longer valid
Routing Context is filled in in fill_notify_route_ctx().
Take the chance to move the logging a bit up in the function, to have
all npar filling together.
Change-Id: I57af18dacc0470d36ddd4705a9530bd44b31f9c0
---
M src/xua_as_fsm.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran
refs/changes/14/42114/1
diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index bdcd0d5..422a2b4 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -128,6 +128,9 @@
if (!asp->fi || asp->fi->state == XUA_ASP_S_DOWN)
continue;
+ LOGPASP(asp, DLSS7, LOGL_INFO, "Tx NOTIFY Type %s:%s (%s)\n",
+ type_name, info_name, info_str);
+
/* Optional: ASP Identifier (if sent in ASP-UP) */
if (asp->remote_asp_id_present) {
npar->presence |= NOTIFY_PAR_P_ASP_ID;
@@ -135,11 +138,8 @@
} else
npar->presence &= ~NOTIFY_PAR_P_ASP_ID;
- /* TODO: Optional Routing Context */
-
- LOGPASP(asp, DLSS7, LOGL_INFO, "Tx NOTIFY Type %s:%s (%s)\n",
- type_name, info_name, info_str);
fill_notify_route_ctx(asp, npar);
+
msg = encode_notify(npar);
osmo_ss7_asp_send(asp, msg);
sent++;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42114?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I57af18dacc0470d36ddd4705a9530bd44b31f9c0
Gerrit-Change-Number: 42114
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
